Hi, we updated knot from 2.4.3 to 2.5.1 and the include statement does not seem to work anymore: error: config, file '/etc/knot/zones.conf', line 5, item 'domain', value 'example.net' (duplicate identifier) error: config, file '/etc/knot/knot.conf', line 73, include '' (duplicate identifier) error: failed to load configuration file '/etc/knot/knot.conf' (duplicate identifier) cat > /etc/knot/knot.conf << 'EOF' # THIS CONFIGURATION IS MANAGED BY PUPPET # see man 5 knot.conf for all available configuration options server: user: knot:knot listen: ["0.0.0.0@53", "::@53"] version: log: - target: syslog any: info key: - id: default algorithm: hmac-sha512 secret: pLEG3Z6uvMtKiQsmOp4tMDyyxENLyJGx8kIbud24tfHdY0uRO82Qix8D2opoA/rndcd2fdt9Ba1LhHDefCK1VQ== remote: - id: ns1 address: ["xxxx1", "yyyy1"] key: default - id: ns2 address: ["xxxx2", "yyyy2"] key: default - id: ns3 address: ["xxxx3", "yyyy3"] key: default acl: - id: notify_from_master action: notify address: ["xxxx1", "yyyy1"] key: default - id: transfer_to_slaves action: transfer address: ["xxxx2", "xxxx2", "xxxx3", "yyyy3"] key: default policy: - id: default_rsa algorithm: RSASHA256 ksk-size: 2048 zsk-size: 1024 template: - id: default file: /var/lib/knot/zones/%s.zone kasp-db: /var/lib/knot/kasp storage: /var/lib/knot - id: master_default acl: ["transfer_to_slaves"] file: /var/lib/knot/zones/%s.zone ixfr-from-differences: on notify: ["ns2", "ns3"] serial-policy: unixtime storage: /var/lib/knot - id: master_dnssec acl: ["transfer_to_slaves"] dnssec-policy: default_rsa dnssec-signing: on file: /var/lib/knot/zones/%s.zone notify: ["ns2", "ns3"] storage: /var/lib/knot zonefile-sync: -1 - id: slave acl: ["notify_from_master"] master: ns1 serial-policy: unixtime storage: /var/lib/knot include: "/etc/knot/zones.conf" EOF cat > /etc/knot/zones.conf << 'EOF' # THIS CONFIGURATION IS MANAGED BY PUPPET # see man 5 knot.conf for all available configuration options zone: - domain: example.net template: slave - domain: example.com template: slave - domain: example.org template: slave EOF If I add the content from zones.conf into knot.conf it works. It seems like the included file gets parsed twice, when I add a domain twice, it will fail at the line with the duplicate zone. If there are no duplicate domains in the file, it always fails at the first domain found. Is this a bug or something with our setup? Regards André _______________________________________________ knot-dns-users mailing list knot-dns-users(a)lists.nic.cz https://lists.nic.cz/cgi-bin/mailman/listinfo/knot-dns-users

Gentlemen, apologies from the team for the breakage and the inconveniences. Could you please retry with 2.5.1-2? The packages should already be available from the repositories for common architectures (the Debian arm builds are taking much longer in qemu). If you happen to compile from source, it should be include_fix branch, soon to be merged to master. Cheers, Ondrej -- Ondřej Surý -- Technical Fellow -------------------------------------------- CZ.NIC, z.s.p.o. -- Laboratoře CZ.NIC Milesovska 5, 130 00 Praha 3, Czech Republic mailto:ondrej.sury@nic.cz https://nic.cz/ -------------------------------------------- ----- Original Message ----- > Hello André, > > I use the same configuration model: knot.conf for general > configuration and include statement with list of domains and their > zone files. > I tried to update Knot to 2.5.1 on my testing server and I confirm, > that there is the problem, that you described. > > I' ve attached knot.conf (unchanged) and example of include file. > > > > -- > S pozdravem > Mgr. František Princ > > > On Fri, Jun 9, 2017 at 9:58 AM, André Keller &lt;ak(a)list.ak.cx&gt; wrote: >> Hi, >> >> we updated knot from 2.4.3 to 2.5.1 and the include statement does not >> seem to work anymore: >> >> error: config, file '/etc/knot/zones.conf', line 5, item 'domain', value >> 'example.net' (duplicate identifier) >> error: config, file '/etc/knot/knot.conf', line 73, include '' >> (duplicate identifier) >> error: failed to load configuration file '/etc/knot/knot.conf' >> (duplicate identifier) >> >> cat > /etc/knot/knot.conf << 'EOF' >> # THIS CONFIGURATION IS MANAGED BY PUPPET >> # see man 5 knot.conf for all available configuration options >> >> server: >> user: knot:knot >> listen: ["0.0.0.0@53", "::@53"] >> version: >> >> log: >> - target: syslog >> any: info >> >> key: >> - id: default >> algorithm: hmac-sha512 >> secret: >> pLEG3Z6uvMtKiQsmOp4tMDyyxENLyJGx8kIbud24tfHdY0uRO82Qix8D2opoA/rndcd2fdt9Ba1LhHDefCK1VQ== >> >> remote: >> - id: ns1 >> address: ["xxxx1", "yyyy1"] >> key: default >> - id: ns2 >> address: ["xxxx2", "yyyy2"] >> key: default >> - id: ns3 >> address: ["xxxx3", "yyyy3"] >> key: default >> >> acl: >> - id: notify_from_master >> action: notify >> address: ["xxxx1", "yyyy1"] >> key: default >> - id: transfer_to_slaves >> action: transfer >> address: ["xxxx2", "xxxx2", "xxxx3", "yyyy3"] >> key: default >> >> policy: >> - id: default_rsa >> algorithm: RSASHA256 >> ksk-size: 2048 >> zsk-size: 1024 >> >> template: >> - id: default >> file: /var/lib/knot/zones/%s.zone >> kasp-db: /var/lib/knot/kasp >> storage: /var/lib/knot >> - id: master_default >> acl: ["transfer_to_slaves"] >> file: /var/lib/knot/zones/%s.zone >> ixfr-from-differences: on >> notify: ["ns2", "ns3"] >> serial-policy: unixtime >> storage: /var/lib/knot >> - id: master_dnssec >> acl: ["transfer_to_slaves"] >> dnssec-policy: default_rsa >> dnssec-signing: on >> file: /var/lib/knot/zones/%s.zone >> notify: ["ns2", "ns3"] >> storage: /var/lib/knot >> zonefile-sync: -1 >> - id: slave >> acl: ["notify_from_master"] >> master: ns1 >> serial-policy: unixtime >> storage: /var/lib/knot >> >> include: "/etc/knot/zones.conf" >> EOF >> >> cat > /etc/knot/zones.conf << 'EOF' >> # THIS CONFIGURATION IS MANAGED BY PUPPET >> # see man 5 knot.conf for all available configuration options >> >> zone: >> - domain: example.net >> template: slave >> - domain: example.com >> template: slave >> - domain: example.org >> template: slave >> EOF >> >> If I add the content from zones.conf into knot.conf it works. It seems >> like the included file gets parsed twice, when I add a domain twice, it >> will fail at the line with the duplicate zone. If there are no duplicate >> domains in the file, it always fails at the first domain found. >> >> Is this a bug or something with our setup? >> >> >> Regards >> André >> _______________________________________________ >> knot-dns-users mailing list >> knot-dns-users(a)lists.nic.cz >> https://lists.nic.cz/cgi-bin/mailman/listinfo/knot-dns-users > > _______________________________________________ > knot-dns-users mailing list > knot-dns-users(a)lists.nic.cz > https://lists.nic.cz/cgi-bin/mailman/listinfo/knot-dns-users